[3.10] Progressive cache fix#35528
Conversation
|
I have tested this item ✅ successfully on 0902640 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35528. |
|
I have tested this item ✅ successfully on 0902640 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35528. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35528. |
|
Merging thanks. |
Obviously this change from the PR here is missing in 4.0-dev yet, see https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/src/Document/HtmlDocument.php#L472 and https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Document/HtmlDocument.php#L559 . I.e. this PR is not a pure back integration of #27000 , and that additional part for not caching the debug module position should be merged up into 4.0-dev. |
Pull Request for Issue # .
Summary of Changes
Backport of #27000 into 3.10
Additionally, we should not cache the
debugposition!And only use the renderer class in cache hash, otherwise the custom renderer can produce the different hash on non-different load, i.e. it's the issue with all YooTheme templates.
Testing Instructions
Enable Joomla debug and progressive caching, load a single page in frontend as a guest, see a cache file in /cache/com_module growing on each page load.
Actual result BEFORE applying this Pull Request
See a cache file in
/cache/com_modulesgrowing on each page load.Expected result AFTER applying this Pull Request
The cache file stays same.
Documentation Changes Required
No.