Merged
Conversation
Member
|
I have tested this item ✅ successfully on ae158f7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27000. |
1 similar comment
|
I have tested this item ✅ successfully on ae158f7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27000. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27000. |
Member
|
Drone error (mysql system test) seems not to be related. |
Contributor
Author
|
I kept restarting the job until it passed 😅 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor Pull Request for Issue #26262 .
Summary of Changes
Only uses the class of the object to serialize for the cache key. With some help from @mbabker (thankyou!!) debugging this it turned out to be an indirect issue from the introduction of Web Assets as they sit in JDocument (a property of the DocumentRenderer class which in turn has a child of the dispatcher which contains Closures).
There's no relevant in the class contents for the module rendering at this point so no issues with this.
Testing Instructions
Go into your websites backend
Go to the Global Configuration
Go to the system tag
Set the System Cache to "ON-Progressive Caching"
Go to your sites frontend
Now you should get an error-message
Now apply patch and redo the Testing Instructions
Documentation Changes Required
N/A