[4.0] Fixed problem with "progressive cache"-option#26262
[4.0] Fixed problem with "progressive cache"-option#26262Schmidie64 wants to merge 4 commits intojoomla:4.0-devfrom
Conversation
| { | ||
| $cache = CmsFactory::getCache('com_modules', ''); | ||
| $hash = md5(serialize(array($name, $attribs, null, $renderer))); | ||
| $hash = md5(serialize(array($name, $attribs, null, json_encode($renderer)))); |
There was a problem hiding this comment.
Can we not just use the class name of the renderer instead of encoding the whole class? Would speed up things a bit or do we need to take here into account the whole object?
There was a problem hiding this comment.
@laoneo If we just take the name, the hash would be different if the content of the renderer differs even though the name is the same I guess. If we just take the name, the hash would always be the same even if the content of the renderer is different.
There was a problem hiding this comment.
Is that true? None of our renderers implement JsonSerializable as an interface. Sadly if i run
json_encode($renderer) and dump that out i currently get
<PathToCMS>/libraries/src/Document/HtmlDocument.php:470:string '{}' (length=2)
|
I have tested this item ✅ successfully on 94a8776 |
|
I have tested this item ✅ successfully on 94a8776 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26262. |
|
I have tested this item ✅ successfully on 01dae5d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26262. |
|
I have tested this item ✅ successfully on 01dae5d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26262. |
|
I have tested this item ✅ successfully on 01dae5d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26262. |
1 similar comment
|
I have tested this item ✅ successfully on 01dae5d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26262. |
|
Later I got problems to show menu items. So check the table: ##_contentitem_tag_map' doesn't exist This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26262. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26262. |
|
I have tested this item ✅ successfully on 01dae5d Thanks for detailed testing instructions :) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26262. |
|
I have tested this item ✅ successfully on 01dae5d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26262. |
|
Whilst this stops the fatal the patch is clearly wrong per Allon's comment as all that is resolved is an empty json string :( |
|
Closing in favour of #27000 |
Summary of Changes
Fixed a problem, in the global configuration->system-tab->System Cache Option.
If "ON - Progressive caching" ist selected and you try to open the frontend, you get an error
Testing Instructions
Go into your websites backend
Go to the Global Configuration
Go to the system tag
Set the System Cache to "ON-Progressive Caching"
Go tot your sites frontend
Now you shout get an error-message
Now apply my patch and redo the Testing Instructions