[4.0] Ignore files and folders of the eos310 plugin in build/deleted_file_check.php#34898
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Jul 25, 2021
Conversation
Contributor
|
Thanks! |
Member
Author
|
Thanks. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Ignore files and folders of the eos310 plugin in build/deleted_file_check.php because files and folders of this plugin will be deleted when uninstalling it, which is implemented with PR #34895 .
In general we handle the repeatable field plugin in the same way.
Testing Instructions
Requirement
It needs a git clone of the CMS repository or your fork of it. A normal installation based e.g. on nightly build will not be enough because the test concerns the "build" folder, which is not included in the installation packages.
For the same reason, this PR cannot be applied with patchtester.
Preparation
Because we don't have a 3.10 nightly build yet which includes the 3.10 EOS plugin, it needs to create a 3.10 full installation package based on the current 3.10-dev branch.
To do that, checkout the 3.10-dev branch. If necessary, update it to latest 3.10-dev of the upstream repository here.
Then open a command window and change directory to the root folder of your git clone.
Now enter following command and wait until it has finished:
After that, you can find the package
Joomla_3.10.0-alpha10-dev-Development-Full_Package.zipin thebuild/tmp/packagesfolder.Save the package somewhere outside of the root folder of your git clone.
If the package build doesn't work for you for some reason, you can download the package from here: https://test5.richard-fath.de/Joomla_3.10.0-alpha10-dev-Development-Full_Package.zip
Now checkout the 4.0-dev branch. If necessary, update it to latest 4.0-dev of the upstream repository here.
Now you can build again a package like described above and find the result
Joomla_4.0.0-rc5-dev-Development-Full_Package.zipagain in folderbuild/tmp/packages, or download the latest 4.0 nightly build from here: https://developer.joomla.org/nightlies/Joomla_4.0.0-rc5-dev-Development-Full_Package.zip .In both cases save the package somewhere outside of the root folder of your git clone.
Now, still being on the 4.0-dev branch, unpack the previously built or downloaded 3.10 and 4.0 packages to the
buildfolder into a folder with the same name as the package, so you have following folder relative to the root:Now you are ready for the test.
Test procedure
On a clean, current 4.0-dev branch prepared as described above, open a command window (e.g. Windows CMD on Windows or bash on Linux) in the root folder of your git clone.
Change directory to the
buildfolder:Result: Three files have been created:
Apply the patch of this PR.
Repeat step 3.
Compare the files generated the previous step 6 with those created in step 3.
Result: The screenshots below show on the left hand side of the comparison the file created in step 6 with this PR applied and on the right hand side the one created in step 3 without this PR applied.
Actual result BEFORE applying this Pull Request
The files and folders of the 3.10 EOS plugin will be included in the lists of files and folders to be deleted on update.
When updating script.php based on these lists and then updating a clean, current 3.10-dev branch to a 4.0 update package with these changes and the changes from PR #34895 , the update will end with following error:
Expected result AFTER applying this Pull Request
The files and folders of the 3.10 EOS plugin will not be included in the lists of files and folders to be deleted on update.
They will be deleted when the plugin is uninstalled after PR #34895 has been merged.
Documentation Changes Required
None.