[4.0] Uninstall and remove 3.10 EOS plugin on update#34895
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Jul 25, 2021
Merged
[4.0] Uninstall and remove 3.10 EOS plugin on update#34895wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 4fe5bd7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34895. |
Contributor
|
I have tested this item ✅ successfully on 4fe5bd7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34895. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34895. |
Contributor
|
Thanks! |
Member
Author
|
Thanks all. |
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) implements uninstalling the 3.10 EOS plugin and removing its files and folders when updating from 3.10.
The code for the new function
uninstallEosPluginhas been taken from relevant parts of the existing functionuninstallRepeatableFieldsPlugin, that's why names quoting is not used everywhere in the query.Since the unquoted names will never be reserved words in any SQL dialect, it should be ok.
But if I get feedback here that I shall change that, I should change it in
uninstallRepeatableFieldsPlugin, too.For updating https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php so it doesn't detect the files and folders of the eos310 plugin as to be deleted, see #34898 .
Testing Instructions
Requirement: It needs a current 3.10-dev branch which includes the 3.10 EOS plugin. The 3.10 nightly doesn't include that yet.
Update a current 3.10-dev branch to latest 4.0 nightly build.
Result: See section "Actual result BEFORE applying this Pull Request" below.
Update a current 3.10-dev branch to the update package or custom update server provided by drone for this PR.
Result: See section "Expected result AFTER applying this Pull Request" below.
Actual result BEFORE applying this Pull Request
After updating an installation with the current 3.10-dev branch which includes the 3.10 EOS plugin to 4.0, the plugin is still present.
Expected result AFTER applying this Pull Request
After updating an installation with the current 3.10-dev branch which includes the 3.10 EOS plugin to 4.0, the plugin is uninstalled and its files and folders have been removed.
Documentation Changes Required
None.