Skip to content

[4.0] Fixing typehints in Smart Search Adapter.php#33920

Merged
chmst merged 1 commit intojoomla:4.0-devfrom
Hackwar:j4findertypehint
May 18, 2021
Merged

[4.0] Fixing typehints in Smart Search Adapter.php#33920
chmst merged 1 commit intojoomla:4.0-devfrom
Hackwar:j4findertypehint

Conversation

@Hackwar
Copy link
Copy Markdown
Member

@Hackwar Hackwar commented May 16, 2021

This is a replacement for #26384.

Summary of Changes

Change typehints + unnamepsaced class usage to namespaced class usage

Testing Instructions

Code reiew

@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 8b2507d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33920.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 17, 2021

I have tested this item ✅ successfully on 8b2507d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33920.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 17, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33920.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 17, 2021
@Quy Quy added this to the Joomla 4.0 milestone May 17, 2021
@chmst chmst merged commit 55732b4 into joomla:4.0-dev May 18, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 18, 2021
@chmst
Copy link
Copy Markdown
Contributor

chmst commented May 18, 2021

Thanks!

@Hackwar Hackwar deleted the j4findertypehint branch January 19, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants