[4.0] Fix some typehints in finder plugins to namespaced versions#26384
Closed
wilsonge wants to merge 7 commits intojoomla:4.0-devfrom
Closed
[4.0] Fix some typehints in finder plugins to namespaced versions#26384wilsonge wants to merge 7 commits intojoomla:4.0-devfrom
wilsonge wants to merge 7 commits intojoomla:4.0-devfrom
Conversation
SharkyKZ
reviewed
Sep 24, 2019
Co-Authored-By: SharkyKZ <sharkykz@gmail.com>
Contributor
|
I have tested this item ✅ successfully on 75d3c08 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26384. |
Quy
reviewed
Sep 24, 2019
| * Method to update index data on category access level changes | ||
| * | ||
| * @param JTable $row A JTable object | ||
| * @param Table $row A JTable object |
Member
|
LGTM. But shouldn't the descriptions not be changed, too, like Quy mentioned? I.e. |
Contributor
|
@wilsonge Please fix the conflicts. |
…4finder-namespace # Conflicts: # administrator/components/com_finder/Indexer/Adapter.php # plugins/finder/categories/categories.php # plugins/finder/contacts/contacts.php # plugins/finder/content/content.php # plugins/finder/newsfeeds/newsfeeds.php # plugins/finder/tags/tags.php
Fix conflicts
Member
|
Sorry, my merge didn't turn out well. The use statements at the top of the finder plugins were doubled. I created a replacement PR with #33920 |
Member
Member
|
yes |
Member
|
Closing in favour of #33920 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Change typehints + unnamepsaced class usage to namespaced class usage
Testing Instructions
Code reiew