fix: Convert session ids returned from PostgreSQL#33822
Merged
chmst merged 4 commits intojoomla:4.0-devfrom May 13, 2021
nibra:postgres-session-id
Merged
fix: Convert session ids returned from PostgreSQL#33822chmst merged 4 commits intojoomla:4.0-devfrom nibra:postgres-session-id
chmst merged 4 commits intojoomla:4.0-devfrom
nibra:postgres-session-id
Conversation
Member
|
@nibra Fix PHP code style errors please: https://ci.joomla.org/joomla/joomla-cms/43569/1/6 |
Member
|
Adding release blocker label as inherited from the issue. |
richard67
reviewed
May 12, 2021
Contributor
|
I have tested this item ✅ successfully on 9313624 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33822. |
Contributor
|
I have tested this item ✅ successfully on 7be5b7c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33822. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 7be5b7c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33822. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33822. |
alikon
approved these changes
May 12, 2021
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33740 . alternative to #33787, #33817, #33819
When reading the session id from the session table on a PostgreSQL database, the result is an array of streams and not of strings.
Summary of Changes
If the session ids returned from the database are streams, they are converted into strings.
Additionally, duplicated code was reduced.
Testing Instructions
see #33740
Actual result BEFORE applying this Pull Request
see #33740
Expected result AFTER applying this Pull Request
Successfull logout. Session destroyed correctly.
Documentation Changes Required
None.