[4.0] Handle session ID being a stream to fix session manager problem on logout with PostgreSQL database#33819
Closed
richard67 wants to merge 1 commit intojoomla:4.0-devfrom
Closed
Conversation
This was referenced May 12, 2021
Member
Author
|
Added release blocker label as inherited from the issue. |
Contributor
|
I have tested this item ✅ successfully on fc07b6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33819. |
This comment was marked as abuse.
This comment was marked as abuse.
Member
Author
|
@SharkyKZ How should it be done in the right way? |
Member
Author
|
@PhilETaylor No need to ping Robert. Maybe we get some info why, or not. Let's wait and see what happens. I am really not the PHP guru, so I'm always open for suggestions/change requests/critics, from whomever it comes. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Member
Author
Member
Author
|
Closing in favour or #33817 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33740 .
Alternative to #33787 and #33817 .
Summary of Changes
When reading the session id from the session table on a PostgreSQL database using loadColumn(), the result is an array of resources and not of strings.
This PR here adds a check in the destroySessions routine of the session manager if the session ID is of type
resourceand the resource type is a stream, and if that is the case, reads the stream and use the result string for the destroySession call.Testing Instructions
See issue #33740 .
Actual result BEFORE applying this Pull Request
See issue #33740 .
Expected result AFTER applying this Pull Request
No errors. Session destroyed correctly. Now back at the login screen.
Documentation Changes Required
None.