Skip to content

[Remove Mootools] Behavior Keepalive without any library dependency.#3376

Merged
mbabker merged 2 commits intojoomla:stagingfrom
hieblmedia:remove-mootools-keepalive
Apr 8, 2014
Merged

[Remove Mootools] Behavior Keepalive without any library dependency.#3376
mbabker merged 2 commits intojoomla:stagingfrom
hieblmedia:remove-mootools-keepalive

Conversation

@hieblmedia
Copy link
Copy Markdown
Contributor

@hieblmedia hieblmedia commented Mar 27, 2014

Keepalive without any library dependency.
I have tried to shrink the code as short as possible.
Should work from IE6 and all other modern Browsers.

@dongilbert
Copy link
Copy Markdown
Contributor

dongilbert commented Mar 27, 2014

👍 Awesome!

@dbhurley
Copy link
Copy Markdown

dbhurley commented Mar 27, 2014

This is great - we'll need to update the associated tests to it passes Travis. Can you update your PR with this?

@hieblmedia
Copy link
Copy Markdown
Contributor Author

hieblmedia commented Mar 28, 2014

Jup, i update the PR soon, when i am back on my dev workstation.

@hieblmedia
Copy link
Copy Markdown
Contributor Author

hieblmedia commented Mar 29, 2014

Test updated.

@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Mar 29, 2014

Yes, vanilla JS!!! It works here

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Mar 29, 2014

Can you open an issue tracker in JoomlaCode (http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103) please? Unfortunately we still track testing there.

@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Mar 29, 2014

I hope I didn't mess up. This should be the JoomlaCode link:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33537

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Mar 29, 2014

@DGT41 It's perfect, thanks!

@Chris-Jones-Gill
Copy link
Copy Markdown

Chris-Jones-Gill commented Mar 29, 2014

I've had an open PR to replace MooTools with jQuery (5 months old, tested, passes Travis, etc).
#2494
vanilla JS is a better solution though, so please someone close mine too when this is merged.
Avoid leaving an orphaned out of date PR live :-)

Bakual pushed a commit to Bakual/joomla-cms that referenced this pull request May 12, 2014
@mbabker
Merge pull request joomla#3376 from hieblmedia/remove-mootools-keepalive
1b9b422 
[Remove Mootools] Behavior Keepalive without any library dependency.
@Fedik Fedik mentioned this pull request Nov 28, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hieblmedia @dongilbert @dbhurley @dgrammatiko @Bakual @Chris-Jones-Gill @mbabker