Skip to content

Updated PR #1841 for Microdata#3252

Closed
mbabker wants to merge 18 commits intojoomla:3.3-devfrom
mbabker:updatedPR1841
Closed

Updated PR #1841 for Microdata#3252
mbabker wants to merge 18 commits intojoomla:3.3-devfrom
mbabker:updatedPR1841

Conversation

@mbabker
Copy link
Copy Markdown
Contributor

@mbabker mbabker commented Mar 7, 2014

This is PR #1841 updated with the current staging branch to assist with testing. I make no assurances on the code's functionality; all I've done is merged up the current code base and resolved any merge conflicts that came up.

@brianteeman
Copy link
Copy Markdown
Contributor

@phproberto
Copy link
Copy Markdown
Contributor

IMO we should avoid to create more useless configuration params. Microdata should be on by default. If you don't like it you can override the templates.

Same for everything related to enable microdata (com_contact config parameter and so).

@alexprut
Copy link
Copy Markdown

I've created a more ordered Pull Request, please take a look here #3330

@parthlawate
Copy link
Copy Markdown
Contributor

Working well. Tested as per instructions at #3330 for Joomla Content Article for Author, Content type & Rating semantic data.

@chiaraaliotta
Copy link
Copy Markdown

Tried the patch and it works well on article. Get excited and tried on contact page, but it is not working. Was it thought just for articles?

@brianteeman
Copy link
Copy Markdown
Contributor

@chiaraaliotta according to the files changed then yes it should apply to contacts as well

@chiaraaliotta
Copy link
Copy Markdown

I think I found a bug: the feature is not obeying the configuration on the contact item level.
Steps to reproduce the bug:

  1. Set the global configuration to enable microdata
  2. Set the microdata option on the contact component level to global
  3. Set the microdata option on the specific contact item to global as well

In this case the microdata is not showing. However, if you explicitly enable the option on the item level, it works.
So this is where the global configuration is not obeying on the item level.

@alexprut
Copy link
Copy Markdown

@chiaraaliotta Could you please test this PR #3330 , it's easier to add one piece at the time, thanks.

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Jun 4, 2014

Closing this PR as it's against an old branch and we merged a different approach for now.
Alex will do a new PR during his GSoC project.

@Bakual Bakual closed this Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants