Updated PR #1841 for Microdata#3252
Updated PR #1841 for Microdata#3252mbabker wants to merge 18 commits intojoomla:3.3-devfrom mbabker:updatedPR1841
Conversation
… com_contact administration panel
…odata in vote plugin
|
IMO we should avoid to create more useless configuration params. Microdata should be on by default. If you don't like it you can override the templates. Same for everything related to enable microdata (com_contact config parameter and so). |
|
I've created a more ordered Pull Request, please take a look here #3330 |
|
Working well. Tested as per instructions at #3330 for Joomla Content Article for Author, Content type & Rating semantic data. |
|
Tried the patch and it works well on article. Get excited and tried on contact page, but it is not working. Was it thought just for articles? |
|
@chiaraaliotta according to the files changed then yes it should apply to contacts as well |
|
I think I found a bug: the feature is not obeying the configuration on the contact item level.
In this case the microdata is not showing. However, if you explicitly enable the option on the item level, it works. |
|
@chiaraaliotta Could you please test this PR #3330 , it's easier to add one piece at the time, thanks. |
|
Closing this PR as it's against an old branch and we merged a different approach for now. |
This is PR #1841 updated with the current staging branch to assist with testing. I make no assurances on the code's functionality; all I've done is merged up the current code base and resolved any merge conflicts that came up.