Skip to content

JMicrodata library/tests, Implementation in the CMS#1841

Closed
alexprut wants to merge 15 commits intojoomla:masterfrom
alexprut:gsoc-semantics
Closed

JMicrodata library/tests, Implementation in the CMS#1841
alexprut wants to merge 15 commits intojoomla:masterfrom
alexprut:gsoc-semantics

Conversation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style - There shouldn't be a space before/after the opening/closing parentheses.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed, it's strange but I don't get any error with the PHP code sniffer tool

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, it's definitely not perfect. A lot of things slip by that only get fixed on visual inspection.

@alexprut
Copy link
Copy Markdown
Author

I'm closing this PR as it is against an outdated branch. Thanks to your feedback a new PR will be made
Thanks all for the comments and testing!

@alexprut alexprut closed this Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants