[4.0] Fix edit account URI fragment#32067
Merged
HLeithner merged 1 commit intojoomla:4.0-devfrom Jan 17, 2021
C-Lodder:patch-1
Merged
[4.0] Fix edit account URI fragment#32067HLeithner merged 1 commit intojoomla:4.0-devfrom C-Lodder:patch-1
HLeithner merged 1 commit intojoomla:4.0-devfrom
C-Lodder:patch-1
Conversation
Member
|
I've tested with success, but the issue tracker doesn't show the PR yet, so I can't mark my test result. There's a small mistake in the "Actual result BEFORE applying this Pull Request" section. It says "Joomla API Token view is shown", but it should be something like "The tab which was opened as last before the last closing is shown, e.g. Joomla API Token view.". |
Member
Author
Member
|
Yes, meanwhile it appears in the tracker, but it hasn't noticed yet that it's a PR and so there is no test button. Will wait a while. |
Member
|
The tracker shows also the wrong build (staging instead of 4.0-dev). |
Member
|
Thanks |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jan 17, 2021
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jan 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix the URI fragment for the
Edit Accountso that it always opens the first tabTesting Instructions
Edit AccountJoomla API TokenClosein the toolbarActual result BEFORE applying this Pull Request
The tab which was opened as last before the last closing is shown, e.g. Joomla API Token view
Expected result AFTER applying this Pull Request
My Profile Details view is shown