Skip to content

[4.0] Form label [a11y]#32060

Merged
wilsonge merged 12 commits intojoomla:4.0-devfrom
brianteeman:form_name
Jan 24, 2021
Merged

[4.0] Form label [a11y]#32060
wilsonge merged 12 commits intojoomla:4.0-devfrom
brianteeman:form_name

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Jan 16, 2021 •
edited
Loading

Each <form> element and form role that needs to be exposed as a landmark must be given an accessible name. This name will allow an assistive technology user to be able to quickly understand the purpose of the form landmark.

You can easily test this with the skipto plugin. Before this PR the item is just Form After this PR the item is either Form: New xxxx or Form: Edit xxx

  • com_banners
  • com_categories
  • com_contact
  • com_content
  • com_fields
  • com_finder
  • com_installer
  • com_languages
  • com_mails
  • com_menus
  • com_messages
  • com_modules
  • com_newsfeeds
  • com_plugins
  • com_privacy
  • com_redirect
  • com_tags
  • com_templates
  • com_users
  • com_workflow

@brianteeman
[4.0] Form label [a11y]
a7891b2 
Each `<form>` element and form role that needs to be exposed as a landmark must be given an accessible name. This name will allow an assistive technology user to be able to quickly understand the purpose of the form landmark.

You can easily test this with the skipto plugin. Before this PR the item is just _Form_ After this PR the item is either _Form: New xxxx_ or _Form: Edit xxx_

- [x]com_categories
- [x]com_contact
- [x]com_content
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jan 16, 2021
@brianteeman brianteeman mentioned this pull request Jan 16, 2021
Closed
Quy
Quy reviewed Jan 16, 2021
View reviewed changes
@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label Jan 16, 2021
@brianteeman brianteeman marked this pull request as ready for review January 16, 2021 15:43
@carcam
Copy link
Copy Markdown

carcam commented Jan 21, 2021

Weird enough the patch does not update the language file so the aria-label shows just the key string...

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jan 21, 2021

Thats probably patchtester bug - i think it has issues when you have a lot of files.

@carcam
Copy link
Copy Markdown

carcam commented Jan 22, 2021

It looks like it. Changes in code reflect the language string so I will test it again and will take that into consideration.

@Quy Quy added the a11y Accessibility label Jan 23, 2021
@wilsonge wilsonge merged commit ea35492 into joomla:4.0-dev Jan 24, 2021
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jan 24, 2021

Merging on review - as if patchtester fails we're unlikely to get many tests and this is a pretty simple patch

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 24, 2021
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jan 24, 2021

thanks

@brianteeman brianteeman deleted the form_name branch January 24, 2021 17:50
@heelc29 heelc29 mentioned this pull request Mar 27, 2022
Closed
heelc29 added a commit to heelc29/joomla that referenced this pull request Mar 27, 2022
@heelc29
add strings
91e634f 
joomla/joomla-cms#32060
@heelc29 heelc29 mentioned this pull request Mar 27, 2022
Closed
@brianteeman brianteeman mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

@bembelimen bembelimen Awaiting requested review from bembelimen

@HLeithner HLeithner Awaiting requested review from HLeithner

Assignees

No one assigned

Labels

a11y Accessibility

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@brianteeman @carcam @wilsonge @Quy @joomla-cms-bot