[4] add missing and fix wrong includes in com_finder, and remove unset on undefined var#32058
Merged
HLeithner merged 2 commits intojoomla:4.0-devfrom Jan 16, 2021
PhilETaylor:addmissingincludes
Merged
[4] add missing and fix wrong includes in com_finder, and remove unset on undefined var#32058HLeithner merged 2 commits intojoomla:4.0-devfrom PhilETaylor:addmissingincludes
HLeithner merged 2 commits intojoomla:4.0-devfrom
PhilETaylor:addmissingincludes
Conversation
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Quy
reviewed
Jan 15, 2021
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Contributor
|
I have tested this item ✅ successfully on ec614a9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32058. |
|
I have tested this item ✅ successfully on ec614a9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32058. |
Member
|
Thanks |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jan 17, 2021
…t on undefined var (joomla#32058) Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jan 20, 2021
…t on undefined var (joomla#32058) Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review
Add missing includes for docblock type hints
Correct incorrect type hint and include that too (FilterTable)
Remote
$tokensfrom theunsetas$tokensis not even set in this method and undefined at this time and place.