[4] Remove unset call as $xml is not set when here#32054
Merged
HLeithner merged 1 commit intojoomla:4.0-devfrom Jan 16, 2021
PhilETaylor:removeunset
Merged
[4] Remove unset call as $xml is not set when here#32054HLeithner merged 1 commit intojoomla:4.0-devfrom PhilETaylor:removeunset
HLeithner merged 1 commit intojoomla:4.0-devfrom
PhilETaylor:removeunset
Conversation
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Member
|
I'm wrong when I say that the $xml is unset automatically on return if not referenced to the object it self or used outside this function? Even the unset in the loop before continue look use less because the $xml will be reassigned in the next run. |
Member
|
Thanks btw |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jan 17, 2021
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Jan 20, 2021
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unset call as $xml is not set when here
Code review.
$xmlis only set in the nested foreach statement, and already unset before the return and continue within that.