[4.0] re-throw the original exception#30653
Merged
infograf768 merged 2 commits intojoomla:4.0-devfrom Sep 16, 2020
alikon:patch-81
Merged
[4.0] re-throw the original exception#30653infograf768 merged 2 commits intojoomla:4.0-devfrom alikon:patch-81
infograf768 merged 2 commits intojoomla:4.0-devfrom
alikon:patch-81
Conversation
|
I have tested this item ✅ successfully on 443dd9e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30653. |
Member
|
I have tested this item ✅ successfully on 443dd9e But that's beyond the scope of this PR. And for now it is better to re-throw the exception here instead of creating a new, identical one, and so this PR is good. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30653. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30653. |
Member
|
tks |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* re-throw the original exception * re-throw the original exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for follow up https://github.com/joomla/joomla-cms/pull/30642/files#r488220693.
Summary of Changes
re-throw the original exception for ArticleModel and ContactModel
Testing Instructions
code review
and/or same test as #30642 and for article