[4.0] Fix extension SQL check for generic components, modules and plugins#30626
Merged
wilsonge merged 7 commits intojoomla:4.0-devfrom Sep 15, 2020
Merged
[4.0] Fix extension SQL check for generic components, modules and plugins#30626wilsonge merged 7 commits intojoomla:4.0-devfrom
wilsonge merged 7 commits intojoomla:4.0-devfrom
Conversation
Contributor
Author
|
Marking as release blocker as this stops the database fixer from working completely when any plugin or module that has a SQL update file is installed |
SharkyKZ
reviewed
Sep 12, 2020
administrator/components/com_installer/src/Model/DatabaseModel.php
Outdated
Show resolved
Hide resolved
SharkyKZ
reviewed
Sep 13, 2020
administrator/components/com_installer/src/Model/DatabaseModel.php
Outdated
Show resolved
Hide resolved
SharkyKZ
reviewed
Sep 13, 2020
administrator/components/com_installer/src/Model/DatabaseModel.php
Outdated
Show resolved
Hide resolved
76fbc2e to
0ea61fa
Compare
Contributor
Author
|
Examples uploaded. Ready to rumble I hope |
Contributor
|
I have tested this item ✅ successfully on ede7746 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30626. |
1 similar comment
Member
|
I have tested this item ✅ successfully on ede7746 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30626. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30626. |
Contributor
Author
|
Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code should work as it is but it's in draft as I need to create some dummy plugins and modules for people to test with.
Summary of Changes
Fixes Joomla database checker for 3rd party modules and plugins
Testing Instructions
Install the following 4 sample extensions:
test_module_admin_update_files.zip
test_module_site_update_files.zip
test_plugin_update_files.zip
test_plugin_wrong_files.zip
there's two plugins, a backend module and a frontend module. Before patch the database checker page will give an exception:
After the patch the checker will show 3 of the extensions (one plugin and two modules) and won't list a plugin that is in an 'unexpected location' (see note on doc required change below if you're interested as to why)
Documentation Changes Required
We need to document that for database fixer to work updates must exist in the format updates/mysql or updates/postgresql (at any level) - if you have mysql/updates as a folder structure the extension will be ignored by the schema checker.