[4.0] Remove unused model class#30600
[4.0] Remove unused model class#30600wilsonge merged 1 commit intojoomla:4.0-devfrom SharkyKZ:j4/php8/cmsmodel
Conversation
|
Is it possible that 3rd party extension use this model? |
|
It's possible. But to maintain PHP 8 compatibility we'd have to either update the method signatures or break class inheritance again, both of which are B/C breaks for anyone extending the class. So I think it's more painless to remove it and have developers extend |
|
I have tested this item ✅ successfully on c27d011 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30600. |
|
Belay that last test - after applying the patch the class is still in the code. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30600. |
|
I have tested this item ✅ successfully on c27d011 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30600. |
|
RTC? |
|
@wilsonge Does anything speak against RTC with respect to the comment above? |
|
No we should be good as it's part of the component. Our B/C promise has never extended into components |
|
Thanks! |
Pull Request for Issue # .
Summary of Changes
Removes unused
Joomla\Component\Config\Site\Model\CmsModelclass which now also errors on PHP 8 due to method signature mismatch.Testing Instructions
Code review?
Documentation Changes Required
IDK.