[4.0] [webauthn] Set a default site name when the option is empty#30520
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Sep 12, 2020
Merged
[4.0] [webauthn] Set a default site name when the option is empty#30520wilsonge merged 1 commit intojoomla:4.0-devfrom
wilsonge merged 1 commit intojoomla:4.0-devfrom
Conversation
|
I have tested this item ✅ successfully on 326b8a1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30520. |
Contributor
|
I have tested this item ✅ successfully on 326b8a1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30520. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30520. |
Contributor
|
Thanks (although not sure how this can be empty?) |
Launch J4 at CloudAccess (J3 have a Site name). |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30517 cc @Formatio-hippocampi
Summary of Changes
Make sure an empty sitename does not break webauthn and fallbacks to a default site name.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Default Sitename is choosen when there is no configured
Documentation Changes Required
none.