[4.0] Admin Module Help strings#30458

Merged

wilsonge merged 2 commits intojoomla:4.0-devfrom

brianteeman:testing

Sep 21, 2020

Contributor

brianteeman commented Aug 23, 2020

This PR corrects one constant which had been duplicated and provides values for the others.

PR for #30457


          [4.0] Admin Module Help strings

76bf14e

This PR corrects one constant which had been duplicated and provides values for the others.

PR for joomla#30457

joomla-cms-bot added Language Change PR-4.0-dev labels

brianteeman mentioned this pull request

[4.0] Missing JHELP strings #30457

Closed

Contributor

ceford commented Aug 25, 2020

I have tested this item ✅ successfully on 76bf14e

I should have made it clearer for other testers: go to Administrator Modules and set the -Select Position- filter to status. Then select each module in turn and click the edit screen Help button.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30458.}

Contributor

ceford commented Aug 25, 2020

I forgot to check the Login Support module. After applying the patch the Help screen has this in the title bar: https://help.joomla.org/proxy?keyref=Help40:JHELP_EXTENSIONS_MODULE_MANAGER_LOGIN_SUPPORT&lang=en which means the string value is not set: Extensions_Module_Manager_Login_Support - I thought that was being included in this PR.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30458.}

Contributor Author

brianteeman commented Aug 25, 2020

My fault - I made a typo - fixing it now

fix

40109db

Contributor

ceford commented Aug 26, 2020

I see the string is fixed. The Help file I created has the wrong name - I need to get a translator admin to do that as I can't once once a file has been marked for translation.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30458.}

ghost commented Sep 7, 2020

I have tested this item ✅ successfully on 40109db

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30458.}

1 similar comment

ChristineWk commented Sep 20, 2020

I have tested this item ✅ successfully on 40109db

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30458.}

Contributor

alikon commented Sep 21, 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30458.}

joomla-cms-bot added the RTC label

wilsonge merged commit 8f483ce into joomla:4.0-dev

Contributor

wilsonge commented Sep 21, 2020

Thanks!

joomla-cms-bot removed the RTC label

wilsonge added this to the Joomla 4.0 milestone

jgerman-bot mentioned this pull request

[4.0] Admin Module Help strings joomlagerman/joomla#1231

Closed

richard67 mentioned this pull request

Change all JHELP value strings in jooml.ini #30712

Merged

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request


          [4.0] Admin Module Help strings (joomla#30458)

b841a5f

brianteeman deleted the testing branch

November 28, 2020 17:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change