[4.0] Installation: Adding a hint on top of Password field#30402
[4.0] Installation: Adding a hint on top of Password field#30402Quy merged 3 commits intojoomla:4.0-devfrom
Conversation
|
Hints are generally considered to be bad for accessibility even though they wont fail automated tests see https://www.smashingmagazine.com/2018/06/placeholder-attribute/ Placing the text between the label and the input and associating it with the input using But please check with the accessibility team |
|
We have many occurences of hint in core. Should it not be solved at that level? |
|
Please ask the accessibility team |
|
@zwiastunsw |
|
Why not expand the label? |
|
The code for In core this is what we have for the Search field It is a text field layout where we have among attributes If I add the same attribute in the password field layout + a description in the xml, i.e. I will get Is it what you want for accessibility? Note: |
|
you should remove the placeholder= |
|
So, what you mean is that the Search field is wrong? I think this is correct. I can obtain a similar result for installation password with the change above and Remains to add the css which is absent from installation Agree? |
|
reading on my phone but that would be correct if you wanted it as a "tooltip" style |
|
Or do as @chmst suggested |
|
@Quy please read the article I linked to which explains why this is a bad idea. Telling me after the input what I should have put in the input is not correct |
|
@Quy will do |
|
@Quy I just added the Folks, please test. |
|
I have tested this item ✅ successfully on bebeccb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30402. |
|
I have tested this item ✅ successfully on bebeccb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30402. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30402. |












Summary of Changes
As installation password must now be at least 12 characters, this adds a hint on top of the field.
Testing Instructions
Patch and install a clean Jooomla
Actual result BEFORE applying this Pull Request
No way to know one needs 12 characters minimum to install joomla
Expected result AFTER applying this Pull Request