[4.0] Fix null value support check for checked_out user id in table class#29272
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom May 30, 2020
Merged
Conversation
wilsonge
approved these changes
May 30, 2020
Member
Author
|
@infograf768 Could you test that with com_localize? |
Member
|
I have tested this item ✅ successfully on 1991163 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29272. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for #29260 (comment).
Summary of Changes
Check null value support in the table (base) class before updating the checked_out column of a table, and write either real
NULLor zero value depending on the result.Testing Instructions
Can be merged by review.
Expected result
3rd party extensions continue to work.
Actual result
3rd party extensions break if the use (J)Table to write into their component-specific table and that table doesn't support
NULLs for the checked_out column.Documentation Changes Required
None.