Skip to content

[4.0] Reviewing Tag Model and Tag Table#29232

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
Hackwar:j4tagscontroller
May 28, 2020
Merged

[4.0] Reviewing Tag Model and Tag Table#29232
wilsonge merged 1 commit intojoomla:4.0-devfrom
Hackwar:j4tagscontroller

Conversation

@Hackwar
Copy link
Copy Markdown
Member

@Hackwar Hackwar commented May 26, 2020

While refactoring the content history feature, I noticed some inconsistencies in the Tag model and the Tag table.

What happened in the Tag model?

  • Fixed docblock for $table
  • Wrapping everything in a try-catch-block, like it is done in other models.
  • Move all JSON encoding to the table class.
  • Remove "rules" handling. We don't have any access management for tags.
  • Set the "new" state properly.

What happened in the Tag table?

  • properly fill the $_jsonEncode attribute, which allows to delete the whole bind() method.

How to test

There should be no difference to before.

@toivo
Copy link
Copy Markdown
Contributor

toivo commented May 27, 2020

I have tested this item ✅ successfully on 9edac4a

Tested successfully in Nightly Build of 27 May in Wampserver 3.2.1 MySQL 8.0.19 PHP 7.4.5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29232.

@bonzani
Copy link
Copy Markdown

bonzani commented May 28, 2020

I have tested this item ✅ successfully on 9edac4a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29232.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 28, 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29232.

@Quy Quy removed the PR-4.0-dev label May 28, 2020
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 28, 2020
@wilsonge wilsonge merged commit 7a0631e into joomla:4.0-dev May 28, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented May 28, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels May 28, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone May 28, 2020
@Hackwar Hackwar deleted the j4tagscontroller branch May 28, 2020 18:42
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
@Hackwar @sakiss
Reviewing Tag Model and Tag Table (joomla#29232)
c6e8a9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilsonge wilsonge wilsonge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Hackwar @toivo @bonzani @Quy @wilsonge @joomla-cms-bot