[4.0] Use unique identifiers in ExtensionHelper::getExtensionRecord()#29230
Merged
HLeithner merged 5 commits intojoomla:4.0-devfrom May 28, 2020
SharkyKZ:j4/bug/extension-record
Merged
[4.0] Use unique identifiers in ExtensionHelper::getExtensionRecord()#29230HLeithner merged 5 commits intojoomla:4.0-devfrom SharkyKZ:j4/bug/extension-record
HLeithner merged 5 commits intojoomla:4.0-devfrom
SharkyKZ:j4/bug/extension-record
Conversation
Member
|
I have tested this item ✅ successfully on 05f4534 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29230. |
1 similar comment
|
I have tested this item ✅ successfully on 05f4534 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29230. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29230. |
Member
|
Thanks |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
…joomla#29230) * Use unique identifiers * Update uses * Update uses * Client check for template * Typehint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Currently,
Joomla\CMS\Extension\ExtensionHelper::getExtensionRecord()uses extension "name" to retrieve extension record. But the name is not standardized, not unique and can not be relied on.This changes the method to be based on element, extension type and, optionally, client ID and folder.
Testing Instructions
Postinstall module and other code using the method should work like before.
Documentation Changes Required
Maybe. Existing uses
Joomla\CMS\Extension\ExtensionHelper::getExtensionRecord()need to be updated to account for changes in function signature.