[4.0] com_mails: string typo & template fields labels display missing#29224
Merged
Quy merged 2 commits intojoomla:4.0-devfrom May 26, 2020
Merged
[4.0] com_mails: string typo & template fields labels display missing#29224Quy merged 2 commits intojoomla:4.0-devfrom
Quy merged 2 commits intojoomla:4.0-devfrom
Conversation
15 tasks
Contributor
|
I have tested this item ✅ successfully on ab7d723 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29224. |
richard67
reviewed
May 26, 2020
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Member
|
I have tested this item ✅ successfully on 409acff This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29224. |
Member
Author
|
rtc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29224. |
Member
|
Restored @toivo 's test result because last change was only a small correction of the language string. |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
…joomla#29224) * [4.0] com_mails: string typo & template fields labels display missing * Update administrator/language/en-GB/com_users.ini Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #28722 (comment)
Summary of Changes
This corrects the language string by taking off
whento getCOM_USERS_MAIL_REMINDER_DESC="This mail is sent to a user by the \"Forgot your username?\" link e.g. in a login form."Can be seen on review.It also corrects the template edit missing labels for the switchers.
Testing Instructions
Display for example index.php?option=com_mails&view=template&layout=edit&template_id=com_config.test_mail&language=fr-FR [Choose any language]
Before patch
After patch