Skip to content

[4.0] Bump Bootstrap to 4.5.0 and jQuery to 3.5#29222

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge:feature/twbs-4.5.0
May 27, 2020
Merged

[4.0] Bump Bootstrap to 4.5.0 and jQuery to 3.5#29222
wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge:feature/twbs-4.5.0

Conversation

@wilsonge
Copy link
Copy Markdown
Contributor

Summary of Changes

Bumps versions of bootstrap and jQuery

Testing Instructions

Navigate around a bit and check the UI isn't horrifically broken anywhere

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 25, 2020
@wilsonge wilsonge changed the title Bump Bootstrap to 4.5.0 and jQuery to 3.5 [4.0] Bump Bootstrap to 4.5.0 and jQuery to 3.5 May 25, 2020
@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 84003a1

Checked in both regular and debug mode
Checked the changelogs for both scripts

Everything seems ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29222.

@C-Lodder
Copy link
Copy Markdown
Member

You can also bump jquery-migrate to 3.3.0

@wilsonge
Copy link
Copy Markdown
Contributor Author

Yeah good shout - updated jQuery migrate too to cover the jQuery bump

@jwaisner
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 78a7006

Checked an UI looks normal after applying. No errors found.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29222.

@wilsonge wilsonge merged commit 4f6e43b into joomla:4.0-dev May 27, 2020
@wilsonge wilsonge deleted the feature/twbs-4.5.0 branch May 27, 2020 08:49
@wilsonge
Copy link
Copy Markdown
Contributor Author

Merging so we can find any small things sooner rather than later then. Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone May 27, 2020
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants