[4.0] Fix edge case PHP Notice in com_finder#27797
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Feb 4, 2020
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 43ae611 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27797. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 43ae611 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27797. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27797. |
Contributor
Author
|
Thanks guys! |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes an edge case in com_finder which gave a PHP Notice
Testing Instructions
Create a category in Joomla such as "Article 0 of 1" and save it. Then check your PHP error log (note due to the redirect to the list view you won't see this in the UI) and you'll find a PHP Notice. Apply patch. After patch the notice is gone.
Alternatively you can code review array_filter PHP documentation which tells you array keys are preserved. Which is bad for our for loop later on line 131 here 4.0-dev...wilsonge:patch-finder#diff-6f122d9d8749e848d0ea1343cf256cd1L131.
Documentation Changes Required
None