[4.0] [plg_fields_subfields] Use namespaced class#27718
Merged
rdeutz merged 2 commits intojoomla:4.0-devfrom Feb 3, 2020
SharkyKZ:j4/fieldsplugin
Merged
[4.0] [plg_fields_subfields] Use namespaced class#27718rdeutz merged 2 commits intojoomla:4.0-devfrom SharkyKZ:j4/fieldsplugin
rdeutz merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/fieldsplugin
Conversation
Quy
reviewed
Jan 31, 2020
Contributor
|
I have tested this item ✅ successfully on 4ffc3d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27718. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 4ffc3d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27718. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27718. |
Member
|
Drone failure seems not to be related to this PR. |
Contributor
|
@richard67 you are right the failure of drone was not realted to the PR, but then we have to restart drone to make sure it is not releated. My personal opinon is that nothing can be RTC when CI has failed. |
Member
|
@rdeutz Well, then tests should be more reliable. Currently it's a kind of lotto if they fail or not. |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
* Use namespaced class * Move _JEXEC check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removes import pointing to non-existing file in favor of namespaced class.
Testing Instructions
Code review is fine.
Documentation Changes Required
No.