[4.0] Routing not working in com_banners#27703
Merged
rdeutz merged 5 commits intojoomla:4.0-devfrom Feb 3, 2020
SharkyKZ:j4/banner-router
Merged
[4.0] Routing not working in com_banners#27703rdeutz merged 5 commits intojoomla:4.0-devfrom SharkyKZ:j4/banner-router
rdeutz merged 5 commits intojoomla:4.0-devfrom
SharkyKZ:j4/banner-router
Conversation
|
I have tested this item ✅ successfully on 818fe5c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27703. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 818fe5c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27703. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27703. |
just doing the change to trigger a build
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
* Fix routing not working in com_banners * Update manifest * CS * Update banners.xml just doing the change to trigger a build Co-authored-by: Robert Deutz <rdeutz@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes routing not working in com_banners.
Testing Instructions
In Banners configuration enable
Track Clicksoption.Create a banner with click URL.
Create a banner module.
Inspect the banner URL in the module.
Expected result
URL like
http://localhost/joomla-cms/index.php/component/banners/click/4.Actual result
URL like
http://localhost/joomla-cms/index.php/component/banners?task=click&id=4.Documentation Changes Required
No.