Skip to content

[4.0] Routing not working in com_contact#27693

Merged
rdeutz merged 3 commits intojoomla:4.0-devfrom
SharkyKZ:j4/contact-routing
Feb 3, 2020
Merged

[4.0] Routing not working in com_contact#27693
rdeutz merged 3 commits intojoomla:4.0-devfrom
SharkyKZ:j4/contact-routing

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

@SharkyKZ SharkyKZ commented Jan 28, 2020

Summary of Changes

Fixes routing not working in com_contact.

Testing Instructions

Create contact category menu item.
View contact item links.

Expected result

SEF links.

Actual result

Non-SEF links.

Documentation Changes Required

IDK.

@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jan 30, 2020

I have tested this item ✅ successfully on 6d1924b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27693.

@astridx
Copy link
Copy Markdown
Contributor

astridx commented Feb 2, 2020

I have tested this successful:

  1. git fetch origin pull/24311/head:ContactFrontendEditJ4

  2. First I made a new installation with standard settings.

  3. I create two contacts

  4. I create a new menu item of the type List Contacts in a Category.

  5. I click menu item List Contacts in a Category and then one item in the list.

  6. I see the url http://localhost/joomla-cms4/index.php/component/contact?view=contact&id=1:test&catid=4

  7. git checkout ContactFrontendEditJ4
    git checkout j4/contact-routing

  8. I click the menu item again and I see http://localhost/joomla-cms4/index.php/list-contacts-in-a-category/1-test

@astridx
Copy link
Copy Markdown
Contributor

astridx commented Feb 2, 2020

I have tested this item ✅ successfully on 6d1924b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27693.

@SharkyKZ
Copy link
Copy Markdown
Contributor Author

SharkyKZ commented Feb 2, 2020

RTC.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27693.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 2, 2020
@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Feb 3, 2020

We have to fix the test here, before we merge it

@rdeutz rdeutz added Unit/System Tests and removed RTC This Pull Request is Ready To Commit Unit/System Tests labels Feb 3, 2020
@astridx
Copy link
Copy Markdown
Contributor

astridx commented Feb 3, 2020

What do mean by "
We have to fix the test here, before we merge it"?

@astridx
Copy link
Copy Markdown
Contributor

astridx commented Feb 3, 2020 •
edited
Loading

Should I test again?
What should I change?

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Feb 3, 2020

@astridx Robert is referring to the failing system tests

@SharkyKZ
Copy link
Copy Markdown
Contributor Author

SharkyKZ commented Feb 3, 2020

Test failure not related to PR. It's tests for Joomla\CMS\Image that fail sometimes.

@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Feb 3, 2020

Test failure not related to PR. It's tests for Joomla\CMS\Image that fail sometimes.

yep got that, had started the build quite some time and it had fail at the same step, but now it is good, so my mouse is hovering over the mergen button, stay tuned :-)

@rdeutz rdeutz merged commit 36f9c01 into joomla:4.0-dev Feb 3, 2020
@Quy Quy added this to the Joomla 4.0 milestone Feb 4, 2020
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
@SharkyKZ @brianteeman
Routing not working in com_contact (joomla#27693)
06193b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

7 participants

@SharkyKZ @jwaisner @astridx @rdeutz @brianteeman @Quy @joomla-cms-bot