Skip to content

[4.0] Backend articles model parameterized queries#27689

Merged
rdeutz merged 13 commits intojoomla:4.0-devfrom
SharkyKZ:j4/prepared/com-content-2
Feb 3, 2020
Merged

[4.0] Backend articles model parameterized queries#27689
rdeutz merged 13 commits intojoomla:4.0-devfrom
SharkyKZ:j4/prepared/com-content-2

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

Summary of Changes

Adds parameterized queries to Joomla\Component\Content\Administrator\Model\ArticlesModel.

Testing Instructions

Go to articles list in backend.
Search and filter articles, use different ordering.

Expected result

Works like before.

Documentation Changes Required

No.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 28, 2020

Home Dashboard > Recently Added Articles

Notice: Undefined property: stdClass::$author_name in \administrator\modules\mod_latest\tmpl\default.php on line 43

@SharkyKZ
Copy link
Copy Markdown
Contributor Author

@Quy Fixed.

@jwaisner
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 46dfe7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27689.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 30, 2020

I have tested this item ✅ successfully on 46dfe7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27689.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 30, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27689.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 30, 2020
@rdeutz rdeutz merged commit cf9f0fd into joomla:4.0-dev Feb 3, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 3, 2020
@Quy Quy added this to the Joomla 4.0 milestone Feb 4, 2020
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
* Query cleanup

* Parameterized queries

* Query cleanup

* Parameterized queries

* Parameterized queries

* Parameterized queries

* Parameterized queries

* CS

* Move columns out of list.select state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants