Merged
Conversation
This option has not done anything for a long time so it should be removed. Yoiu can confirm this bt testing the editor AFTER applying the PR and you will see that you get the correct tinymce mobile experience As shown in the screenshots below (I will deal with the toggle button in another PR)
Contributor
|
I have tested this item 🔴 unsuccessfully on 1aefa3a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27501. |
Member
|
I have tested this item ✅ successfully on 1aefa3a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27501. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 1aefa3a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27501. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27501. |
Member
|
please solve the conflict |
Contributor
Author
|
resolved |
Member
|
Thanks |
Contributor
Author
|
thanks a lot |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
This option has not done anything for a long time so it should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option has not done anything for a long time so it should be removed.
Yoiu can confirm this bt testing the editor AFTER applying the PR and you will see that you get the correct tinymce mobile experience
As shown in the screenshots below
(I will deal with the toggle button in another PR)