[4.0] Menu item edit: Correcting Unassigned and Unpublished Modules assignment#27492
Conversation
|
It works the first time, but if you hide it again, you get a blank row.
|
|
I get the same result. I even tested with the "unassigned module" toggle and it did the same thing. Created empty rows if I toggled either more than once. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27492. |
|
I have tested this item ✅ successfully on 114971d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27492. |
|
I have tested this item ✅ successfully on 55ead68 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27492. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27492. |
|
There is vertical spacing issue when hiding unassigned modules, but can be done in a different PR.
|
Is this a regression? If you then you should remove the RTC tag |
|
Will look at this tomorrow, not sure it is regression as the only changes concern class remove |
|
I can not replicate @Quy findings - all looks good to me |
|
I confirm no issue here. |
|
Thanks |
Pull Request for Issue #27491
Summary of Changes
remove
hiddenclass when Unassigned Modules or Unpublished Modules are set toShowTesting Instructions
See #27491
After patch
The rows are no more empty and show the Display and Published badges correctly.