Skip to content

[4.0] Remove unnecessary markup#27482

Merged
HLeithner merged 2 commits intojoomla:4.0-devfrom
Quy:remove-markup
Jan 14, 2020
Merged

[4.0] Remove unnecessary markup#27482
HLeithner merged 2 commits intojoomla:4.0-devfrom
Quy:remove-markup

Conversation

@Quy
Copy link
Copy Markdown
Contributor

@Quy Quy commented Jan 11, 2020

Summary of Changes

Remove unnecessary markup to make it consistent with identical code here:
https://github.com/joomla/joomla-cms/pull/27445/files#diff-3541cae319fabd8eddc585b3a8b770e9R39

Testing Instructions

Code review.

or

Edit a site module.
Go to Menu Assignment tab.
See Menu Selection.
No visible changes before/after the PR.

@jwaisner
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 8248aed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27482.

1 similar comment
@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 8248aed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27482.

@Quy Quy removed the PR-4.0-dev label Jan 14, 2020
@Quy
Copy link
Copy Markdown
Contributor Author

Quy commented Jan 14, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27482.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 14, 2020
@HLeithner HLeithner merged commit d670b9f into joomla:4.0-dev Jan 14, 2020
@HLeithner
Copy link
Copy Markdown
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 14, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Jan 14, 2020
@Quy Quy deleted the remove-markup branch January 14, 2020 16:45
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants