Skip to content

[4.0] TinyMCE image button#27467

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
brianteeman:image_button
Jan 11, 2020
Merged

[4.0] TinyMCE image button#27467
wilsonge merged 3 commits intojoomla:4.0-devfrom
brianteeman:image_button

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Similar to #24765 but thus time it was the image button that was missing.

Apply the PR
Check that the image button appears in the wysiwyg editor in

  1. Content item
  2. Plugin options set 0
  3. Plugin options list of available buttons

image

Similar to joomla#24765 but thus time it was the image button that was missing.

Apply the PR
Check that the image button appears in the wysiwyg editor in
1. Content item
2. Plugin options set 0
3. Plugin options list of available buttons
@jwaisner
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on ebc0625


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27467.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 10, 2020

I have tested this item ✅ successfully on ebc0625


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27467.

@Quy Quy removed the PR-4.0-dev label Jan 10, 2020
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 10, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27467.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 10, 2020
@wilsonge wilsonge merged commit bb1dc01 into joomla:4.0-dev Jan 11, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 11, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 11, 2020
@brianteeman
Copy link
Copy Markdown
Contributor Author

Thanks

@wilsonge
Copy link
Copy Markdown
Contributor

And just for people in the future Brian meant to link to #27467

@brianteeman brianteeman deleted the image_button branch January 11, 2020 00:19
@brianteeman
Copy link
Copy Markdown
Contributor Author

Why would I link this PR to this PR ;)

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Similar to joomla#24765 but thus time it was the image button that was missing.

Apply the PR
Check that the image button appears in the wysiwyg editor in
1. Content item
2. Plugin options set 0
3. Plugin options list of available buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants