Merged
Conversation
(there may be a better way to do this but I couldnt find it) ### Before ### After
Member
|
I have tested this item 🔴 unsuccessfully on 1f57e61 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27466. |
Member
|
After patching and completing npm i, the alignment did not change as the expected result. I tested this in Firefox and Chrome. |
Contributor
Author
|
Did you run npm i to rebuild the scripts? |
Contributor
|
I have tested this item ✅ successfully on 1f57e61 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27466. |
Contributor
|
@jwaisner Try clearing browser's cache. |
Member
|
I have tested this item ✅ successfully on 1f57e61 @Quy just tried that and it didnt work End result, I did a complete reset of my environment and it works as expected. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27466. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27466. |
This comment has been minimized.
This comment has been minimized.
Member
|
no, sorry, ignore my previous comment |
Contributor
Author
|
Thanks |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
(there may be a better way to do this but I couldnt find it) ### Before ### After
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(there may be a better way to do this but I couldnt find it)
Before
After
testing
don't forget npm i