Skip to content

[4.0] Aria-controls [a11y]#27454

Merged
Quy merged 1 commit intojoomla:4.0-devfrom
brianteeman:sidebar
Jan 9, 2020
Merged

[4.0] Aria-controls [a11y]#27454
Quy merged 1 commit intojoomla:4.0-devfrom
brianteeman:sidebar

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

The code to display the toggle toolbar button on a mobile view has the incorrect aria-controls value

It is a simple copy paste error and fixed by this PR

The code to display the toggle toolbar button on a mobile view has the incorrect aria-controls value

It is a simple copy paste error and fixed by this PR
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 9, 2020

I have tested this item ✅ successfully on fe9db4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27454.

1 similar comment
@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jan 9, 2020

I have tested this item ✅ successfully on fe9db4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27454.

@Quy Quy removed the PR-4.0-dev label Jan 9, 2020
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 9, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27454.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2020
@Quy Quy merged commit 03f9059 into joomla:4.0-dev Jan 9, 2020
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Jan 9, 2020
@Quy Quy added this to the Joomla 4.0 milestone Jan 9, 2020
@brianteeman
Copy link
Copy Markdown
Contributor Author

Thanks

@brianteeman brianteeman deleted the sidebar branch January 9, 2020 20:48
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
The code to display the toggle toolbar button on a mobile view has the incorrect aria-controls value

It is a simple copy paste error and fixed by this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants