J Installation: loss of session when getting to the "remove" view#27439
Merged
infograf768 merged 3 commits intojoomla:4.0-devfrom Jan 9, 2020
Merged
J Installation: loss of session when getting to the "remove" view#27439infograf768 merged 3 commits intojoomla:4.0-devfrom
infograf768 merged 3 commits intojoomla:4.0-devfrom
Conversation
Member
|
I have tested this item ✅ successfully on 4ab2399 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27439. |
Member
|
Will test tomorrow. Hint: no need to use the French installation folder from J3. |
Contributor
Author
|
Yah sorry. Ones a language and ones imposter syndrome language :p |
Member
|
I have tested this item ✅ successfully on 11d6b64 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27439. |
Member
|
tks. One less. :) |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
…omla#27439) * Fix session hash changing mid-installation * Ensure the file handler is consistent in the db Co-authored-by: infograf768 <infografjms@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #25130 .
Summary of Changes
Fixes the session handler to be consistent during the installation (in both name and handler) so that before and after the configuration file is written you preserve your session
Testing Instructions
Copy down the french language pack for the installation directory from Joomla 3. Run the installer in french and check after installation on the success page that Joomla is still in french (obviously there will be some strings in english/missing things as you've copied the old 3.x pack)
Documentation Changes Required
None