Merged
Conversation
After the language files were renamed the xml needs to be updated as well. (I still don't see why we have the files in here anyway but thats another topic)
Quy
reviewed
Jan 7, 2020
build.xml
Outdated
| <mkdir dir="${basedir}/build/com_joomlaupdate-pkg/staging/admin/language" /> | ||
| <copyfile src="${basedir}/administrator/language/en-GB/en-GB.com_joomlaupdate.ini" dest="${basedir}/build/com_joomlaupdate-pkg/staging/admin/language/en-GB.com_joomlaupdate.ini"/> | ||
| <copyfile src="${basedir}/administrator/language/en-GB/en-GB.com_joomlaupdate.sys.ini" dest="${basedir}/build/com_joomlaupdate-pkg/staging/admin/language/en-GB.com_joomlaupdate.sys.ini"/> | ||
| <copyfile src="${basedir}/administrator/language/en-GB/en-GB.com_joomlaupdate.ini" dest="${basedir}/build/com_joomlaupdate-pkg/staging/admin/language/en-GB/com_joomlaupdate.ini"/> |
Contributor
|
Agree with removing the prefix. However I also wonder why they are even there. I'm going to merge this by review. |
Contributor
Author
|
thanks |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
* [4.0] Language manifest After the language files were renamed the xml needs to be updated as well. (I still don't see why we have the files in here anyway but thats another topic) * i think so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the language files were renamed the xml needs to be updated as well. (I still don't see why we have the files in here anyway but thats another topic)
Testing Instructions
code review