Skip to content

[4.0] Allow to a switcher and validate assets to be overridable#27417

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
Fedik:overidable-asset1
Jan 7, 2020
Merged

[4.0] Allow to a switcher and validate assets to be overridable#27417
wilsonge merged 2 commits intojoomla:4.0-devfrom
Fedik:overidable-asset1

Conversation

@Fedik
Copy link
Copy Markdown
Member

@Fedik Fedik commented Jan 6, 2020

Summary of Changes

A little fix, to keep these 2 assets overridable to avoid problems similar to #27024

Testing Instructions

Apply patch, run npm install

Check the form validation and switcher styling.

Expected result

All works

Actual result

All works

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 6, 2020
@SharkyKZ
Copy link
Copy Markdown
Contributor

SharkyKZ commented Jan 7, 2020

I have tested this item ✅ successfully on dfa1ff9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27417.

1 similar comment
@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jan 7, 2020

I have tested this item ✅ successfully on dfa1ff9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27417.

@Quy Quy removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 7, 2020
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 7, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27417.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 7, 2020
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 7, 2020
@wilsonge wilsonge merged commit cae0a2d into joomla:4.0-dev Jan 7, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jan 7, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 7, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 7, 2020
@Fedik Fedik deleted the overidable-asset1 branch January 7, 2020 19:06
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants