Skip to content

[4.0] [com_config] Fix when saving configuration in frontend#27284

Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom
SharkyKZ:j4/error/com_config
Jan 8, 2020
Merged

[4.0] [com_config] Fix when saving configuration in frontend#27284
wilsonge merged 6 commits intojoomla:4.0-devfrom
SharkyKZ:j4/error/com_config

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

Partial Pull Request for Issue #27283.

Summary of Changes

Corrects parent classes in models.
Adds missing administrator form path.
Removes obsolete paths.

Testing Instructions

Create menu items for Configuration Manager » Site Configuration Options and Configuration Manager » Display Template Options menu item types.
View them in frontend.
Save the forms.

Expected result

Works.

Actual result

{"error":true,"code":0,"message":"Form::loadForm could not load file"}

Documentation Changes Required

No.

@infograf768
Copy link
Copy Markdown
Member

Test:
Concerning site settings:
No more error but after Save we are redirected to the same page displaying the form, i.e. we have no Save and Close with a redirect to where we came from.

@SharkyKZ
Copy link
Copy Markdown
Contributor Author

Same as in 3.x.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Dec 16, 2019

I have tested this item ✅ successfully on ded2751

Same as in 3.x.

yep. Would be good to improve this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27284.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Dec 19, 2019

I have tested this item ✅ successfully on ded2751


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27284.

@Quy Quy removed the PR-4.0-dev label Dec 19, 2019
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Dec 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27284.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 19, 2019
@Quy Quy added the PR-4.0-dev label Dec 19, 2019
@wilsonge wilsonge merged commit d3cf0cb into joomla:4.0-dev Jan 8, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jan 8, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 8, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 8, 2020
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants