Skip to content

[4.0] search button border#27241

Closed
brianteeman wants to merge 1 commit intojoomla:4.0-devfrom
brianteeman:search-border
Closed

[4.0] search button border#27241
brianteeman wants to merge 1 commit intojoomla:4.0-devfrom
brianteeman:search-border

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Summary of Changes

The border colour of the appended button on the search button in the admin should not have a different colour to the rest of the button

Before

image

After

image

@ciar4n
Copy link
Copy Markdown
Contributor

ciar4n commented Dec 11, 2019

This changes the border color to grey? The button color is primary (dark blue).

@brianteeman
Copy link
Copy Markdown
Contributor Author

Yes that is correct because imho it is not a regular button but part of the larger search element in the same way that the dropdown indicator is styled

image

@ciar4n
Copy link
Copy Markdown
Contributor

ciar4n commented Dec 12, 2019

Yes that is correct because imho it is not a regular button but part of the larger search element in the same way that the dropdown indicator is styled

I see your point but have to disagree. A dropdown indicator is part of a field and indicates how a user selects an option from that field. A button in a search group is a separate element (consider tab indexing). They are only really grouped for aesthetics. Consider Bootstraps default styling for these elements (same is true for most frameworks)...

image

Personally I think the issue here is how Joomla 4s dropdowns are designed to look like form groups.

Aesthetically I also think that considering the background is also often gray, at first glance the search button looks incorrectly sized.

@brianteeman
Copy link
Copy Markdown
Contributor Author

They are only really grouped for aesthetics.

Hence this pull request

@ciar4n
Copy link
Copy Markdown
Contributor

ciar4n commented Dec 12, 2019

Then apply the button background color (--atum-bg-dark) to the border color (https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/bootstrap/_buttons.scss#L6).

The grey border is lost on the grey background and just looks like the button is 2px smaller than the input.

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Dec 12, 2019

Then apply the button background color (--atum-bg-dark) to the border color

Then it would apply to all buttons and not just this appended button

just looks like the button is 2px smaller than the input.

I dont see that

@ciar4n
Copy link
Copy Markdown
Contributor

ciar4n commented Dec 12, 2019

Then it would apply to all buttons and not just this appended button

As it should. We don't need to micro style the button for every single use case. It just results in bloated, difficult to maintain css. Not to mention an irregular design across the ui. The whole point of using bootstrap was to avoid this.

@brianteeman
Copy link
Copy Markdown
Contributor Author

So I can't "micro style" but everyone else can :sigh:

@ciar4n
Copy link
Copy Markdown
Contributor

ciar4n commented Dec 12, 2019

Seems like we can't discuss the best approach here either. Do as you wish. I'm out.

@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jan 7, 2020

I have tested this item ✅ successfully on a8bc8be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27241.

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Jan 9, 2020
As the atum scss for searchtools was moved recently this PR is a redo of joomla#27240 and joomla#27241
@brianteeman
Copy link
Copy Markdown
Contributor Author

Closed see #27458

@brianteeman brianteeman closed this Jan 9, 2020
@brianteeman brianteeman deleted the search-border branch January 9, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants