is this a work in progress ?
as example this one has not been added from #16141
https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/form/field/color/advanced.php

@twsvaishali please extend this for aria-*

is this a work in progress ?
as example this one has not been added from #16141
https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/form/field/color/advanced.php

Have added remaining fields in latest commits. Please check.

@twsvaishali please extend this for aria-*

Can we start new PR for this?

Have added remaining fields in latest commits. Please check.

seems fine now thanks

yes maybe another PR for the aria-*

@alikon @twsvaishali for the aria-* all is needed is a var ariaAttributes
and adding

				// Check for aria attribute
 				if (strpos($name, "aria-") === 0 && array_key_exists($name, $this->ariaAttributes))
 				{
 					return $this->ariaAttributes[$name];
 				}

in the main class and some minor adjustments in the layouts. Of course it can be done in another PR to make things easier for testing. I just had to mention that, since a11y is always an afterthought...

@twsvaishali since you're redoing this maybe we could change the layouts logic to:

if (!empty($dataAttributes)) {
	// Data attributes - data-*
	$dataAttribute = '';

	foreach ($dataAttributes as $key => $attrValue)
	{
		$dataAttribute .= ' ' . $key . '="' . htmlspecialchars($attrValue, ENT_COMPAT, 'UTF-8') . '"';
	}
}

In essence the loop will execute only if there are any data-* attributes defined.
Micro optimisation? Maybe, maybe not, I haven't benchmarked the code but this seems reasonable...

@dgrammatiko Yes. Will start another PR for the aria-* once this is tested and merged. Also I am actually not sure if all fields will have area attribute.

I have tested this item ✅ successfully on d46baf1

Works so far.

Maybe some fields are missing because they did not exist (yet) when this PR was made.

It needs someone who checks for completeness and if necessary makes a new PR.

Same with the idea to do the same for "aria-" attributes, this should be done in another PR, too.

I have tested this item ✅ successfully on d46baf1

RTC

@wilsonge @Quy What about the following field layouts? They are not touched by this PR. Shall they be done, too?

• checkboxes.php
• color/slider.php
• contenthistory.php
• radio/buttons.php
• radio/switcher.php
• tag.php

Thanks all!