[com_categories] - convert to prepared statement#27205
Merged
HLeithner merged 25 commits intojoomla:4.0-devfrom Jan 6, 2020
alikon:patch-125
Merged
[com_categories] - convert to prepared statement#27205HLeithner merged 25 commits intojoomla:4.0-devfrom alikon:patch-125
HLeithner merged 25 commits intojoomla:4.0-devfrom
alikon:patch-125
Conversation
Quy
reviewed
Dec 3, 2019
administrator/components/com_categories/Field/CategoryeditField.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Dec 3, 2019
administrator/components/com_categories/Field/Modal/CategoryField.php
Outdated
Show resolved
Hide resolved
…d.php Co-Authored-By: Quy <quy@fluxbb.org>
…eld.php Co-Authored-By: Quy <quy@fluxbb.org>
Quy
reviewed
Dec 3, 2019
administrator/components/com_categories/Model/CategoriesModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Dec 3, 2019
administrator/components/com_categories/Model/CategoriesModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Dec 3, 2019
administrator/components/com_categories/Model/CategoriesModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Dec 3, 2019
administrator/components/com_categories/Model/CategoriesModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Dec 3, 2019
administrator/components/com_categories/Model/CategoriesModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Dec 3, 2019
administrator/components/com_categories/Model/CategoryModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Dec 3, 2019
administrator/components/com_categories/Model/CategoryModel.php
Outdated
Show resolved
Hide resolved
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Contributor
Edit a category but unable to save. |
Quy
reviewed
Dec 4, 2019
administrator/components/com_categories/Model/CategoryModel.php
Outdated
Show resolved
Hide resolved
Co-Authored-By: Quy <quy@fluxbb.org>
Contributor
Author
|
that i could be burned on 🔥 |
Quy
reviewed
Dec 4, 2019
administrator/components/com_categories/Model/CategoryModel.php
Outdated
Show resolved
Hide resolved
Contributor
|
I have tested this item ✅ successfully on 8ad3883 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27205. |
SharkyKZ
reviewed
Dec 12, 2019
|
|
||
| if (($this->element['parent'] == true || $jinput->get('option') == 'com_categories') | ||
| && (isset($row) && !isset($options[0])) | ||
| if ($oldCat != 0 && ($this->element['parent'] == true || $jinput->get('option') == 'com_categories') |
Contributor
There was a problem hiding this comment.
Why the changes here and to the query below?
Member
|
I have tested this item ✅ successfully on 8ad3883 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27205. |
Contributor
|
RTC. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27205. |
Member
|
Thanks |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
Co-authored-by: Quy <quy@fluxbb.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
use prepared statement for SQL
Testing Instructions
test com_categories
Expected result
works as before
Actual result
N/A