Skip to content

Remove submitted values from data if field is disabled#25682

Merged
HLeithner merged 5 commits intojoomla:stagingfrom
degobbis:FixFormFieldValidationForDisabledFields
Jul 30, 2019
Merged

Remove submitted values from data if field is disabled#25682
HLeithner merged 5 commits intojoomla:stagingfrom
degobbis:FixFormFieldValidationForDisabledFields

Conversation

@degobbis
Copy link
Copy Markdown
Contributor

Pull Request for Issue #25652 .

Testing Instructions

see #25628

@gogicomputers
Copy link
Copy Markdown

I have tested this item ✅ successfully on 4bb2e3a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 4bb2e3a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

@Quy Quy removed the PR-staging label Jul 22, 2019
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jul 22, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 22, 2019
@HLeithner
Copy link
Copy Markdown
Member

@laoneo can you have a look at this because i'm not quite confident with this.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 23, 2019
@HLeithner HLeithner reopened this Jul 23, 2019
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jul 23, 2019

Me neither, pretty sure this will introduce a regression.

@degobbis
Copy link
Copy Markdown
Contributor Author

@laoneo Could you please describe in more detail why this would introduce a regression?
The only problem I still see are disabled fields which are also required, but we already have the problem and I can take care of that in a next step.

@degobbis
Copy link
Copy Markdown
Contributor Author

@laoneo @HLeithner I have restored the previous state, as I do not really fully understand when a default value is needed. The only adjustment now concerns what, according to the description, anyway should not be.
If the field is disabled, and the browser still sends data, then I will delete it again.
I hope now there should be no reason to hold back the fix.

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jul 25, 2019

@degobbis can't say exactly what, it is just so a feeling. It took a couple of iterations till we were on a stable state with all these readonly, disabled states and access level settings including the passed array. What I can remember is that we had issues with values not being present in the data array as they were needed to clear values, etc.

@degobbis
Copy link
Copy Markdown
Contributor Author

@laoneo However, we are currently receiving an error message because the values from disabled fields are still sent. With my fix, I'm only making sure that the described procedure of the Bowser is actually executed. Either way, the same result.

@degobbis
Copy link
Copy Markdown
Contributor Author

@gogicomputers @viocassel Could You please test my changes again?

@d4shoerncheN
Copy link
Copy Markdown

I have tested this item ✅ successfully on 174136c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

1 similar comment
@gogicomputers
Copy link
Copy Markdown

I have tested this item ✅ successfully on 174136c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

@ghost
Copy link
Copy Markdown

ghost commented Jul 26, 2019

Status "Ready To Commit".

Thanks for tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 26, 2019
@HLeithner HLeithner merged commit 7faa14f into joomla:staging Jul 30, 2019
@HLeithner
Copy link
Copy Markdown
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 30, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Jul 30, 2019
@degobbis degobbis deleted the FixFormFieldValidationForDisabledFields branch July 30, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants