Skip to content

Fix broken submit if disabled fields are prefilled#25628

Closed
degobbis wants to merge 2 commits intojoomla:stagingfrom
degobbis:FixFormFieldValidationForDisabledFields
Closed

Fix broken submit if disabled fields are prefilled#25628
degobbis wants to merge 2 commits intojoomla:stagingfrom
degobbis:FixFormFieldValidationForDisabledFields

Conversation

@degobbis
Copy link
Copy Markdown
Contributor

@degobbis degobbis commented Jul 18, 2019

Fixed on #25682

Summary of Changes

Fix broken submit if disabled fields are prefilled by comparing submitted value with the value filled before.

Testing Instructions

  1. Create a custom field from the type media and disable the permission to edit custom field value for the group Manager.
  2. Edit in backend the article with this custom field as a super user and as an example select an image.
  3. Login in frontend with the user in the group Manager and edit the article with this custom field and safe it without any changes.

Expected result

The article will be submitted and saved.

Actual result

This will show a warning with invalid field.

@degobbis degobbis force-pushed the FixFormFieldValidationForDisabledFields branch from 9dfdf06 to 19c0413 Compare July 18, 2019 13:29
@gogicomputers
Copy link
Copy Markdown

I have tested this item 🔴 unsuccessfully on 19c0413


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25628.

@degobbis
Copy link
Copy Markdown
Contributor Author

Thanks for the test.
The bug is real, but this solution only seems to work on my test installation. I have to analyze which extension intervenes and if there is another solution to solve it.

In any case, my patch is wrong so I will close it.
I will open an issue, maybe someone will find a solution before of me.
Issue #25652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants