Skip to content

Fix field name on messages#25626

Merged
HLeithner merged 3 commits intojoomla:stagingfrom
degobbis:FixFormWarningLabel
Jul 23, 2019
Merged

Fix field name on messages#25626
HLeithner merged 3 commits intojoomla:stagingfrom
degobbis:FixFormWarningLabel

Conversation

@degobbis
Copy link
Copy Markdown
Contributor

@degobbis degobbis commented Jul 18, 2019

Summary of Changes

Output field label on messages/warnings if exist

Testing Instructions

  1. Create a custom field from the type media and disable the permission to edit custom field value for the group Manager.
  2. Edit in backend the article with this custom field as a super user and as an example select an image.
  3. Login in frontend with the user in the group Manager and edit the article with this custom field and safe it without any changes.

This will show a warning wich is a bug that I will hopfully fix with an other PR
update here is the fix #25682

Expected result

The warning shown prints the field label to define the errorfield

Actual result

The warning shown prints the field name to define the errorfield, which may be named differently from the label and therefore may not be findable

@gogicomputers
Copy link
Copy Markdown

I have tested this item ✅ successfully on 7f96f48

Code Works


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25626.

@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 7f96f48


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25626.

@Quy Quy removed the PR-staging label Jul 22, 2019
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jul 22, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25626.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 22, 2019
@HLeithner
Copy link
Copy Markdown
Member

$fieldName is a misleading name for the variable could you please change it to $fieldLabel or $messageLabel.

thx

@degobbis
Copy link
Copy Markdown
Contributor Author

degobbis commented Jul 23, 2019

@HLeithner changed the name from the variable to $fieldLabel

@HLeithner HLeithner merged commit 2271541 into joomla:staging Jul 23, 2019
@HLeithner
Copy link
Copy Markdown
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 23, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Jul 23, 2019
@degobbis degobbis deleted the FixFormWarningLabel branch July 27, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants