Skip to content

Document loadmoduleid in plugin description#25076

Merged
HLeithner merged 4 commits intojoomla:stagingfrom
Quy:patch-2
Jun 5, 2019
Merged

Document loadmoduleid in plugin description#25076
HLeithner merged 4 commits intojoomla:stagingfrom
Quy:patch-2

Conversation

@Quy
Copy link
Copy Markdown
Contributor

@Quy Quy commented May 31, 2019

Pull Request for Issue #25074.

Summary of Changes

Add loadmoduleid syntax in plugin description.

Testing Instructions

Code review
or

  • Go to settings of plugin Content - Load Modules.
  • Read the description.

PLG_LOADMODULE_FIELD_VALUE_RAW="No wrapping (raw output)"
PLG_LOADMODULE_FIELD_VALUE_TABLE="Wrapped by table (column)"
PLG_LOADMODULE_XML_DESCRIPTION="Within content this plugin loads Module positions, Syntax: {loadposition user1} or Modules by name, Syntax: {loadmodule mod_login}. Optionally can specify module style and for loadmodule a specific module by title, Syntax: {loadmodule mod_login,module title,style}."
PLG_LOADMODULE_XML_DESCRIPTION="Within content this plugin loads Modules by ID, Syntax: {loadmoduleid 1} or Module positions, Syntax: {loadposition user1} or Modules by name, Syntax: {loadmodule mod_login}. Optionally can specify module style and for loadmodule a specific module by title, Syntax: {loadmodule mod_login,module title,style}."
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman May 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLG_LOADMODULE_XML_DESCRIPTION="Within content this plugin loads a Module by ID, Syntax: {loadmoduleid 1} or a Module by position, Syntax: {loadposition user1} or a Module by name, Syntax: {loadmodule mod_login}. Optionally can specify module style and for loadmodule a specific module by title, Syntax: {loadmodule mod_login,module title,style}."

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 4098f7a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25076.

1 similar comment
@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 4098f7a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25076.

@Quy
Copy link
Copy Markdown
Contributor Author

Quy commented May 31, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25076.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 31, 2019
@ReLater
Copy link
Copy Markdown
Contributor

ReLater commented Jun 1, 2019

Optionally can specify module style

moduleid can't. See #25072
That's why I had problems to write a correct description yesterday on my own.

@Quy
Copy link
Copy Markdown
Contributor Author

Quy commented Jun 5, 2019

Will this work? Optionally can specify module style (except for loadmoduleid)

@HLeithner HLeithner merged commit fb088b2 into joomla:staging Jun 5, 2019
@HLeithner
Copy link
Copy Markdown
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 5, 2019
@HLeithner HLeithner added this to the Joomla 3.9.7 milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants