Load module by id should also get the style#25072
Load module by id should also get the style#25072yozmag wants to merge 5 commits intojoomla:3.10-devfrom
Conversation
loadmoduleid plugin keyword changed to get the module chrome style.
Co-Authored-By: ReLater <ReLater@users.noreply.github.com>
Co-Authored-By: ReLater <ReLater@users.noreply.github.com>
Co-Authored-By: ReLater <ReLater@users.noreply.github.com>
Co-Authored-By: ReLater <ReLater@users.noreply.github.com>
|
Won't this impact existing sites? |
|
And isn't it a new feature that won't go into Joomla 3? I'm not sure because pr is for Joomla 3.10 branch. |
|
If a site now uses loadmoduleid it loads the 'none' chrome'. If the parameter on the plugin is different option '-1' https://docs.joomla.org/Understanding_Output_Overrides#Module_Chrome the plugin is going to render the chrome select in the plugin parameter instead of 'none' and will impact the render of the module. |
I think your pr is a new feature and not a bug fix. New features won't go into Joomla 3. You have to rebase it to Joomla 4. But let's decide the 3.9 Release Lead @HLeithner |
|
It's seams not to be a b/c break but a new feature, so sry please rebase of J4. |
|
I think this is a bug because the parameter is on the plugin is not taken to account when render the module like with keyword {loadposition xxxx} and {loadmodule xxxx} the styles (modChrome_style) is working. Also adding the style as parameter also works as described in joomla documentation . The load {loadmoduleid xx} was added feature on the 3.9 this doesn't make sense not to make correct only on J4, and J3. stays with the bug. |
loadmoduleid plugin keyword changed to get the module chrome style.
Pull Request for Issue # .
Summary of Changes
Changed to allow the chrome style with loadmoduleid keyword
Testing Instructions
Expected result
The chrome style should change if the plugin parameter changes or a 2nd argument is defined.
Actual result
Nothing changes always the none chrome is render.
Documentation Changes Required